Skip to content

Removed dependency from bcmi-labs/arduino-modules #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2018
Merged

Removed dependency from bcmi-labs/arduino-modules #102

merged 1 commit into from
Dec 17, 2018

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Dec 14, 2018

Fix #98

@cmaglie cmaglie added this to the next alpha preview milestone Dec 14, 2018
@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Linux 64: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-27-PR102-linux64.tar.bz2

⬇️ Linux 32: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-27-PR102-linux32.tar.bz2

⬇️ Linux ARM: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-27-PR102-linuxarm.tar.bz2

⬇️ Windows: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-27-PR102-windows.zip

⬇️ OSX: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-27-PR102-osx.zip

ℹ️ To test this build:

  1. Just replace arduino-cli binary with the provided one

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #102 into master will decrease coverage by 0.07%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   47.86%   47.78%   -0.08%     
==========================================
  Files          92       92              
  Lines        4095     4112      +17     
==========================================
+ Hits         1960     1965       +5     
- Misses       1898     1910      +12     
  Partials      237      237
Impacted Files Coverage Δ
commands/board/attach.go 16.12% <0%> (+0.66%) ⬆️
commands/upload/upload.go 12.06% <0%> (ø) ⬆️
commands/commands.go 49.23% <100%> (ø) ⬆️
commands/compile/compile.go 59.76% <100%> (ø) ⬆️
arduino/sketches/sketches.go 30.55% <31.03%> (-9.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0031c6d...1afe59d. Read the comment docs.

@cmaglie cmaglie merged commit c120bbb into arduino:master Dec 17, 2018
@cmaglie cmaglie deleted the removed-removed-dep branch December 17, 2018 11:36
per1234 added a commit that referenced this pull request Nov 16, 2020
@per1234
Fix false negatives during CI build (#102)
e7fd93c 
The previous configuration would only fail if the last compilation of one of the list items failed. Failure of any of the prior compilations in the list item would be masked by a successful final compilation.
per1234 added a commit that referenced this pull request Aug 9, 2021
@per1234
Merge pull request #102 from arduino/per1234/improve-output2
dab9db8 
Improve error output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.4-alpha.preview
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @ArduinoBot